Skip to content

Weth PCV Deposit#127

Merged
Joeysantoro merged 3 commits intomasterfrom
feat/wethPCVDepositBase
Aug 17, 2021
Merged

Weth PCV Deposit#127
Joeysantoro merged 3 commits intomasterfrom
feat/wethPCVDepositBase

Conversation

@Joeysantoro
Copy link
Contributor

Refactors some WETH-related code to allow for more modular PCV components where WETH is needed

This will be useful for an Aave ETH PCV deposit because Aave uses WETH

Copy link
Contributor

@eswak eswak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have weird space/tab mixup & non-consistent indentation (sometimes 4, sometimes 2 spaces) in WethPCVDeposit.sol.

But nothing critical. Good idea to factor these functions in a base contract 🙂

@Joeysantoro Joeysantoro force-pushed the feat/wethPCVDepositBase branch from f82b7a3 to 1b687b7 Compare August 14, 2021 22:27
@Joeysantoro Joeysantoro merged commit df3a9ed into master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments