Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new access control role and modifier available to every contract in the system called the Contract Admin
The Contract Admin is a role grantable by the Governor through the same Core access control module. The intention is for it to be used in "optimistic governance". The security assumptions will be different from the Guardian. The Guardian is intended to act instantly and only pause functionality.
Contract Admins should be either a multisig gated by a timelock or an autonomous smart contract.
For the former case, they can act without explicit DAO approval but the DAO can reject any proposal.
The first use case for optimistic governance will be the TribalChief, and future use cases can include FeiRari, portfolio composition/rebalancing, and parameterization changes.