split bonding curve purchase to optimize gas#1
Merged
Joeysantoro merged 1 commit intomasterfrom Jan 7, 2021
Merged
Conversation
Joeysantoro
commented
Jan 7, 2021
|
|
||
| function _incentivize() internal virtual { | ||
| if (isTimeEnded()) { | ||
| _initTimed(); |
Contributor
Author
There was a problem hiding this comment.
Resets the incentive time window. I can add a comment in code or rename the function to _resetTimed if that is helpful
Joeysantoro
commented
Jan 7, 2021
| bondingCurveOracle.init(bondingcurve.getAveragePrice(balance)); | ||
|
|
||
| bondingcurve.purchase{value: balance}(genesisGroup, balance); | ||
| bondingcurve.allocate(); |
Contributor
Author
There was a problem hiding this comment.
Added so Genesis group launch also allocates the PCV
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits up the bonding curve purchase flow into "purchase" and "allocate". This saves the average purchaser from incurring the allocation gas costs and batches them.
Purchase gas before 300k
Purchase gas after 100k
Allocate gas after 230k
Allocation is incentivized over a time window that resets each period but it can be called any time.