Merge pull request #749 from fei-protocol/fix-failing-tests

thomas-waite · web-flow · commit 438d19a24cf0 · 2022-04-27T16:32:52.000+01:00
Fix failing tests
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -55,7 +55,7 @@
     "@gnosis.pm/safe-deployments": "^1.12.0",
     "@gnosis.pm/safe-ethers-lib": "^1.1.0",
     "@nomiclabs/hardhat-waffle": "^2.0.3",
-    "@openzeppelin/contracts": "^4.6.0-rc.0",
+    "@openzeppelin/contracts": "4.6.0",
     "@openzeppelin/test-environment": "^0.1.7",
     "@openzeppelin/test-helpers": "^0.5.15",
     "@orcaprotocol/contracts": "^5.0.1",
diff --git a/test/unit/pcv/utils/RatioPCVControllerV2.test.ts b/test/unit/pcv/utils/RatioPCVControllerV2.test.ts
@@ -571,7 +571,7 @@ describe('RatioPCVControllerV2', function () {
             pcvController
               .connect(impersonatedSigners[pcvControllerAddress])
               .transferFrom(pcvDepositEth.address, token.address, userAddress, pcvAmount, {}),
-            'ERC20: transfer amount exceeds allowance'
+            'ERC20: insufficient allowance'
           );
         });
 
@@ -677,7 +677,7 @@ describe('RatioPCVControllerV2', function () {
             pcvController
               .connect(impersonatedSigners[pcvControllerAddress])
               .transferFromRatio(pcvDepositEth.address, token.address, userAddress, '10000', {}),
-            'ERC20: transfer amount exceeds allowance'
+            'ERC20: insufficient allowance'
           );
         });
 
diff --git a/test/unit/peg/FixedPricePSM.test.ts b/test/unit/peg/FixedPricePSM.test.ts
@@ -812,7 +812,7 @@ describe('FixedPricePSM', function () {
         await fei.connect(impersonatedSigners[minterAddress]).mint(userAddress, 100);
         await expectRevert(
           psm.connect(impersonatedSigners[userAddress]).redeem(userAddress, 100, 0),
-          'ERC20: transfer amount exceeds allowance'
+          'ERC20: insufficient allowance'
         );
       });
     });
diff --git a/test/unit/peg/MintRedeemPausePSM.test.ts b/test/unit/peg/MintRedeemPausePSM.test.ts
@@ -553,7 +553,7 @@ describe('PegStabilityModule', function () {
         await fei.connect(impersonatedSigners[minterAddress]).mint(userAddress, 10_000_000);
         await expectRevert(
           psm.connect(impersonatedSigners[userAddress]).redeem(userAddress, 1, 0),
-          'ERC20: transfer amount exceeds allowance'
+          'ERC20: insufficient allowance'
         );
       });
     });
diff --git a/test/unit/peg/PegStabilityModule.test.ts b/test/unit/peg/PegStabilityModule.test.ts
@@ -454,7 +454,7 @@ describe('PegStabilityModule', function () {
         await fei.connect(impersonatedSigners[minterAddress]).mint(userAddress, 10_000_000);
         await expectRevert(
           psm.connect(impersonatedSigners[userAddress]).redeem(userAddress, 1, 0),
-          'ERC20: transfer amount exceeds allowance'
+          'ERC20: insufficient allowance'
         );
       });
     });
diff --git a/test/unit/staking/TribalChiefPart2.test.ts b/test/unit/staking/TribalChiefPart2.test.ts
@@ -404,7 +404,7 @@ describe('TribalChief', () => {
     it('should not be able to deposit without LPToken approval', async function () {
       await expectRevert(
         this.tribalChief.connect(impersonatedSigners[userAddress]).deposit(pid, totalStaked, 100),
-        'ERC20: transfer amount exceeds allowance'
+        'ERC20: insufficient allowance'
       );
     });
 
