Skip to content

fix: Add, delete, edit table#1598

Merged
joondotcode merged 3 commits intomasterfrom
fix/add-delete-table
Apr 3, 2026
Merged

fix: Add, delete, edit table#1598
joondotcode merged 3 commits intomasterfrom
fix/add-delete-table

Conversation

@joondotcode
Copy link
Copy Markdown
Contributor

@joondotcode joondotcode commented Apr 2, 2026

Changes

  • Reverted the earlier approach because it relied on JS column-width measurement and locking the table layout on first render. That made the table too rigid and caused regressions in real hosted forms, especially in responsive/container-based layouts where the table needs to resize after load.
  • Replaced it with a CSS-only solution for edit mode. Instead of recalculating and fixing column widths in JS, the editor is positioned inside the existing cell so editing doesn’t change the table’s layout or push adjacent columns.

Checklist before requesting a review

  • Cleaned up debug prints, comments, and unused code
  • Tested end to end
  • Included screenshots or walkthrough video of change if impacts UX

Related pull requests

PR #1597

Screen.Recording.2026-04-01.at.10.21.56.PM.mov

Link other PRs here that are related to this change

@joondotcode joondotcode requested a review from trebitowski as a code owner April 2, 2026 02:19
@joondotcode
Copy link
Copy Markdown
Contributor Author

Updated to use textarea for editing instead of inputElement

Screen.Recording.2026-04-02.at.11.57.40.AM.mov

@joondotcode joondotcode force-pushed the fix/add-delete-table branch from 2abb8a2 to 7e38504 Compare April 2, 2026 15:59
@joondotcode joondotcode merged commit cd04502 into master Apr 3, 2026
7 checks passed
@joondotcode joondotcode deleted the fix/add-delete-table branch April 3, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants