Skip to content

feat: Add, delete, edit functionality for table element#1596

Merged
joondotcode merged 5 commits intomasterfrom
feat/table-add-column
Apr 1, 2026
Merged

feat: Add, delete, edit functionality for table element#1596
joondotcode merged 5 commits intomasterfrom
feat/table-add-column

Conversation

@joondotcode
Copy link
Copy Markdown
Contributor

@joondotcode joondotcode commented Mar 29, 2026

Changes

  • Add in ability for the user to add, edit and delete table element
  • When editing is enabled, row clicks no longer fire the onClick callback at all, only button click is enabled

Checklist before requesting a review

  • Cleaned up debug prints, comments, and unused code
  • Tested end to end
  • Included screenshots or walkthrough video of change if impacts UX

Related pull requests

https://github.com/feathery-org/feathery-frontend/pull/3154

Add, delete, edit table

Screen.Recording.2026-03-29.at.1.12.52.PM.mov

Modifying table element will persist

Screen.Recording.2026-03-29.at.1.13.42.PM.mov

Link other PRs here that are related to this change

@joondotcode
Copy link
Copy Markdown
Contributor Author

Adding delete functionality within the overflow menu, prevent layout shift when editing

Screen.Recording.2026-03-31.at.1.27.38.PM.mov

@joondotcode joondotcode force-pushed the feat/table-add-column branch from fae453c to fff1377 Compare March 31, 2026 17:33
@joondotcode joondotcode merged commit 5dfa3f0 into master Apr 1, 2026
7 checks passed
@joondotcode joondotcode deleted the feat/table-add-column branch April 1, 2026 01:38
joondotcode added a commit that referenced this pull request Apr 1, 2026
joondotcode added a commit that referenced this pull request Apr 1, 2026
joondotcode added a commit that referenced this pull request Apr 2, 2026
joondotcode added a commit that referenced this pull request Apr 2, 2026
joondotcode added a commit that referenced this pull request Apr 3, 2026
* Revert "Revert "feat: Add, delete, edit functionality for table element (#1596)" (#1597)"

This reverts commit 31fdab3.

* fix: Prevent layout shift on edits using pure css

* fix: Use textarea for table cell editing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants