Skip to content

fix: remove early calls to setActiveStep#1594

Merged
trebitowski merged 1 commit intomasterfrom
fix/early-step-rendering
Mar 29, 2026
Merged

fix: remove early calls to setActiveStep#1594
trebitowski merged 1 commit intomasterfrom
fix/early-step-rendering

Conversation

@trebitowski
Copy link
Copy Markdown
Collaborator

Changes

updateFieldStyles, updateFieldOptions, and updateFieldProperties all call setActiveStep early. This causes the step to render before the logic rule finishes. Rendered step is interactive and can cause unexpected behavior when the changes before the original logic rule can finish.

Checklist before requesting a review

  • Cleaned up debug prints, comments, and unused code
  • Tested end to end
  • Included screenshots or walkthrough video of change if impacts UX

Related pull requests

Link other PRs here that are related to this change

@trebitowski trebitowski force-pushed the fix/early-step-rendering branch from 56a86f6 to 3a9bf33 Compare March 28, 2026 21:28
@trebitowski trebitowski force-pushed the fix/early-step-rendering branch from 3a9bf33 to 30a005a Compare March 29, 2026 19:35
@trebitowski trebitowski merged commit 86d6d2d into master Mar 29, 2026
7 checks passed
@trebitowski trebitowski deleted the fix/early-step-rendering branch March 29, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants