Skip to content

fix: Render country flag emojis on Windows in phone field#1589

Merged
trebitowski merged 1 commit intomasterfrom
fix/phone-flag-emoji-rendering
Mar 27, 2026
Merged

fix: Render country flag emojis on Windows in phone field#1589
trebitowski merged 1 commit intomasterfrom
fix/phone-flag-emoji-rendering

Conversation

@trebitowski
Copy link
Copy Markdown
Collaborator

@trebitowski trebitowski commented Mar 25, 2026

Summary

  • Adds country-flag-emoji-polyfill to the PhoneField component
  • Calls polyfillCountryFlagEmojis() on PhoneField mount — scoped only to this component, no global side effects
  • Adds "Twemoji Country Flags" to font-family on the flag trigger and dropdown list items

The polyfill uses platform detection and only downloads a font (~78kB) on browsers that need it. macOS/iOS/Android users are unaffected.

Notion PRD: https://www.notion.so/32e753ac481581d3a539c58a9dd3ac16

Testing checklist

Network list Phone field with flag emojis
  • Country flag emojis render as flags (not two-letter codes) on Windows
  • Flag rendering is unchanged on macOS
  • The country selector trigger and the dropdown list both show flags correctly

@trebitowski trebitowski self-assigned this Mar 25, 2026
@trebitowski trebitowski changed the title fix: render country flag emojis on Windows in phone field fix: Render country flag emojis on Windows in phone field Mar 25, 2026
@trebitowski trebitowski force-pushed the fix/phone-flag-emoji-rendering branch from 2774165 to 0f50360 Compare March 25, 2026 18:37
@trebitowski trebitowski requested a review from joondotcode March 25, 2026 18:37
Add country-flag-emoji-polyfill to PhoneField so that flag emojis
render correctly on Windows (and other platforms where the default
emoji font lacks flag support). The polyfill is loaded on mount,
scoped to PhoneField only, and degrades gracefully if it fails to load.
@trebitowski trebitowski force-pushed the fix/phone-flag-emoji-rendering branch from 0f50360 to d52c9f7 Compare March 27, 2026 05:22
@trebitowski trebitowski merged commit 193c9ae into master Mar 27, 2026
7 checks passed
@trebitowski trebitowski deleted the fix/phone-flag-emoji-rendering branch March 27, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants