fix: Form no validate on hidden_fields#1587
Merged
joondotcode merged 2 commits intomasterfrom Mar 25, 2026
Merged
Conversation
joondotcode
changed the title
trebitowski
approved these changes
Mar 24, 2026
joondotcode
force-pushed
the
fix/form-no-validate
branch
from
0afc92b to
d3bb40c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Problem: When a form has required fields hidden via CSS (e.g. conditional logic), clicking Submit causes the browser to throw a "not focusable" error because it tries to show a validation tooltip on an invisible element
Solution: Instead of calling
reportValidity()on the entire form, loop through form elements and call it on the first one that is both invalid and visible.Checklist before requesting a review
Related pull requests
Link other PRs here that are related to this change