fix: Skip AB test is overriding user id#1585
Merged
trebitowski merged 1 commit intomasterfrom Mar 24, 2026
Merged
Conversation
joondotcode
approved these changes
Mar 23, 2026
trebitowski
force-pushed
the
fix/ab-test
branch
from
749f135 to
3752d03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes a bug when opening submissions on AB test forms. AB tests choose which form to load based on the user id and the form title. If the
user_Aopensform_Aand the AB test checksuser_Aandform_A. If it chooses to display the variant, thenform_Bis loaded and the submission will exist onform_B.Later, if someone opens the submission, the AB test will check
user_Aandform_B. If this check also chooses to display the variant, thenform_Aloads and the submission doesn't map toform_A's fields.Solution
Skip the variant logic if we are overriding the user id. This means that when loading a submission, it will always display the form the submission was on, regardless of AB test status.