feat: Update file fields from server logic rule response#1581
Merged
trebitowski merged 1 commit intomasterfrom Mar 18, 2026
Merged
feat: Update file fields from server logic rule response#1581trebitowski merged 1 commit intomasterfrom
trebitowski merged 1 commit intomasterfrom
Conversation
bo-dun-1
reviewed
Mar 13, 2026
| // Handle file values the same way as the session v3 endpoint: | ||
| // convert { url, path } to Promise<File> and track S3 paths | ||
| if (response?.file_values) { | ||
| const filePromises = objectMap(response.file_values, (fileOrFiles: any) => |
Contributor
There was a problem hiding this comment.
can any logic be unified with session endpoint?
bo-dun-1
approved these changes
Mar 13, 2026
trebitowski
force-pushed
the
feat--server-rule-blob
branch
from
c91221f to
c795df6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updates file fields from the server logic rule response
https://github.com/feathery-org/feathery-backend/pull/3035
Checklist before requesting a review
Related pull requests
Link other PRs here that are related to this change