Add redis timeout configuration option & Serving Configuration Refactoring #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Moskalenko <[email protected]>
Signed-off-by: Oleksii Moskalenko <[email protected]>
Signed-off-by: Oleksii Moskalenko <[email protected]>
Signed-off-by: Oleksii Moskalenko <[email protected]>
pyalex
changed the title
Signed-off-by: Oleksii Moskalenko <[email protected]>
Signed-off-by: Oleksii Moskalenko <[email protected]>
khorshuheng
pushed a commit
to khorshuheng/feast-java
that referenced
this pull request
Mar 10, 2021
…oring (feast-dev#8) * add redis timeout option Signed-off-by: Oleksii Moskalenko <[email protected]> * fix typo Signed-off-by: Oleksii Moskalenko <[email protected]> * remove StoreProto.Store Signed-off-by: Oleksii Moskalenko <[email protected]> * remove StoreProto.Store Signed-off-by: Oleksii Moskalenko <[email protected]> * fix test Signed-off-by: Oleksii Moskalenko <[email protected]> * clean up Signed-off-by: Oleksii Moskalenko <[email protected]>
khorshuheng
pushed a commit
that referenced
this pull request
Mar 10, 2021
…oring (#8) * add redis timeout option Signed-off-by: Oleksii Moskalenko <[email protected]> * fix typo Signed-off-by: Oleksii Moskalenko <[email protected]> * remove StoreProto.Store Signed-off-by: Oleksii Moskalenko <[email protected]> * remove StoreProto.Store Signed-off-by: Oleksii Moskalenko <[email protected]> * fix test Signed-off-by: Oleksii Moskalenko <[email protected]> * clean up Signed-off-by: Oleksii Moskalenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Moskalenko [email protected]
Add
timeoutas configurable option for Redis Cluster client.Refactoring: Since there's no need in subscriptions and other options (from StoreProto) that are not used anymore I removed any mentions of
StoreProto.Storefrom Serving. Instead I propose to use Config classes that will be part of storage module.