Update ukrainian city locales to the modern ones#3127
Merged
stefannibrasil merged 1 commit intofaker-ruby:mainfrom Nov 19, 2025
Merged
Conversation
Contributor
stefannibrasil
left a comment
stefannibrasil
left a comment
There was a problem hiding this comment.
All the new names are cities, according to my search, except for Хрустальний, which seems to be a movie. Can you check that? Thanks!
| - Конотоп | ||
| - Краматорськ | ||
| - Красний Луч | ||
| - Хрустальний |
Contributor
There was a problem hiding this comment.
When I search for this, I get a movie instead of a city. Do you see a city when you search for it?
Contributor
Author
There was a problem hiding this comment.
Hey, thanks for the notice. Yeah, it's both a movie name and a city name
https://en.wikipedia.org/wiki/Khrustalnyi
https://uk.wikipedia.org/wiki/%D0%A5%D1%80%D1%83%D1%81%D1%82%D0%B0%D0%BB%D1%8C%D0%BD%D0%B8%D0%B9
stefannibrasil
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because since the introduction of ukrainian locales, some cities have been renamed, so the locales need to be updated.
Additional information
List of renamed cities.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator or locale: