fix #3114: prevent scientific notation when generating bank account number#3118
Merged
thdaraujo merged 1 commit intofaker-ruby:mainfrom Nov 1, 2025
Merged
Conversation
stefannibrasil
pushed a commit
that referenced
this pull request
Jan 8, 2026
…3118) Co-authored-by: Ahmed Hisham <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created to fix issue #3114, a bug in
Faker::Bank.account_numberwhere generated values could sometimes include scientific notation (e.g., 3512553848424886e-05) due to usingrand.to_s[2..].This resulted in invalid bank account numbers containing non-digit characters.
The new implementation ensures that account numbers always consist of digits only.
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator or locale: