Skip to content

Fix nl phone format#3050

Merged
stefannibrasil merged 2 commits intofaker-ruby:mainfrom
klaaspieter:fix-nl-phone-format
Feb 26, 2025
Merged

Fix nl phone format#3050
stefannibrasil merged 2 commits intofaker-ruby:mainfrom
klaaspieter:fix-nl-phone-format

Conversation

@klaaspieter
Copy link
Contributor

@klaaspieter klaaspieter commented Feb 21, 2025

Motivation / Background

This Pull Request has been created because faker generates invalid Dutch phone numbers.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

stefannibrasil
stefannibrasil reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you share a bit more of why these are valid now?

@klaaspieter
Copy link
Contributor Author

klaaspieter commented Feb 26, 2025

Sure! Previously Dutch phone numbers were using a fallback country code (I don't recall the exact one) which made them invalid. I think technically the only thing to make them valid is to use the correct +31 country code.

My PR also adds cell phone number format because only numbers starting with 06 are valid Dutch cell phone numbers. The 06 prefix is reserved for that purpose.

Thinking about it I think I could update my PR so that 06 numbers are part of the normal format as well because they are valid phone number. I think my change makes it so they will never be generated when asking for a normal phone number. Only when asking for a cell phone number.

stefannibrasil
stefannibrasil approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing more context. LGTM 👍🏼

@stefannibrasil stefannibrasil merged commit 3b6efaf into faker-ruby:main Feb 26, 2025
7 checks passed
@klaaspieter klaaspieter deleted the fix-nl-phone-format branch February 27, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefannibrasil stefannibrasil stefannibrasil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@klaaspieter @stefannibrasil