Drop support for Ruby 2.7#3006
Merged
stefannibrasil merged 2 commits intofaker-ruby:mainfrom Oct 18, 2024
Merged
Conversation
stefannibrasil
approved these changes
Oct 16, 2024
Contributor
stefannibrasil
left a comment
stefannibrasil
left a comment
There was a problem hiding this comment.
thank you @tatheerf02 and @ayana-s 🎉
Contributor
|
@tatheerf02 we have some RuboCop failures. Are you okay with fixing them as well? |
…nces to 2.7 Co-authored-by: Ayana Siddiqui [email protected]
tatheerf02
force-pushed
the
drop-ruby-2.7
branch
from
eaab4f0 to
be56200
Compare
tatheerf02
force-pushed
the
drop-ruby-2.7
branch
from
be56200 to
a148f62
Compare
Contributor
Author
@stefannibrasil Thanks for pointing those out! I've pushed up a separate commit with those fixes now :) |
stefannibrasil
approved these changes
Oct 18, 2024
Contributor
stefannibrasil
left a comment
stefannibrasil
left a comment
There was a problem hiding this comment.
Loved the cleanups! Thank you ⭐
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored by: @ayana-s
Motivation / Background
Fixes #2885
This Pull Request has been created because Ruby 3.0 is now EOL and the Faker team aims to only maintain support for one EOL version at a time. This means that support for Ruby 2.7 can be dropped.
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]