Fix benchmark:all_methods task by excluding Faker::Deprecator module from benchmark target#2988
Merged
koic merged 1 commit intofaker-ruby:mainfrom Aug 11, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
I found that the benchmark task
rake benchmark:all_methodsis not working on current main branch.So here's a patch that makes the task runnable again.
Additional information
The task has been broken since f586da7 that added a new module named
Faker::Deprecator. And this patch just adds it to the ignore module list.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]