Fix invalid IANA time zone identifier for Atlantic/Cape_Verde#2927
Fix invalid IANA time zone identifier for Atlantic/Cape_Verde#2927thdaraujo merged 2 commits intofaker-ruby:mainfrom
Atlantic/Cape_Verde#2927Conversation
|
Unrelated, but I'm not sure it makes sense to translate the time zone names at all, since they're identifiers. Here's an example: time_zone: [África/Argel, África/Cairo, África/Casablanca, África/Harare, ...]/faker/lib/locales/es-MX.yml:15
This quote from Theory and pragmatics of the tz code and data - Timezone identifiers hints that the timezone names can be mapped to translations, but the unique identifier aspect gets lost if the timezone's name itself is translated. |
…Atlantic/Cape_Verde in en.faker.address.time_zone
c9c1de0 to
678f0d3
Compare
thdaraujo
left a comment
There was a problem hiding this comment.
excellent, thanks for adding tests!
Atlantic/Cape_Verde
Motivation / Background
Fixes: #2928
This Pull Request has been created because our tests using Faker time zones mostly pass, but fails when the
Atlantic/Cabo_Verdetime zone is returned. We validate that time zones are valid IANA identifiers, andAtlantic/Cabo_Verdeis calledAtlantic/Cape_Verdein the Time Zone Database.Additional information
tzcode and data - Timezone identifierstzinfogem.tzinfogem as well.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]