Fix flaky spec on TestFakerFile#test_file_name#2868
Merged
thdaraujo merged 1 commit intofaker-ruby:mainfrom Dec 13, 2023
Merged
Fix flaky spec on TestFakerFile#test_file_name#2868thdaraujo merged 1 commit intofaker-ruby:mainfrom
TestFakerFile#test_file_name#2868thdaraujo merged 1 commit intofaker-ruby:mainfrom
Conversation
TestFakerFile#test_file_name
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes: #2867
The regex matcher for
test_file_namewasn't matching the extensions with a number (.mp3, .mp4), this PR updates the matcher to include alphanumeric to it.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator: