Remove deprecate safe_email and free_email methods#2841
Merged
stefannibrasil merged 7 commits intofaker-ruby:mainfrom Nov 22, 2023
Merged
Remove deprecate safe_email and free_email methods#2841stefannibrasil merged 7 commits intofaker-ruby:mainfrom
stefannibrasil merged 7 commits intofaker-ruby:mainfrom
Conversation
hatsu38
changed the title
Contributor
stefannibrasil
left a comment
stefannibrasil
left a comment
There was a problem hiding this comment.
Thanks for working on this! I left one small comment that needs to be addressed. This PR also needs to be rebased with main to fix the merge conflicts. Thanks!
| construct_email(sanitized_local_part, generate_domain) | ||
| end | ||
|
|
||
| ## |
Contributor
There was a problem hiding this comment.
We can remove extend Gem::Deprecate from line 18 as well.
stefannibrasil
added
🙏🏽 PR: Needs Further Updates
and removed
⏲️ PR: In Queue for Review
labels
Contributor
Author
|
I fixed conflicts with main! |
stefannibrasil
approved these changes
Nov 22, 2023
Contributor
stefannibrasil
left a comment
stefannibrasil
left a comment
There was a problem hiding this comment.
Yay, thanks for doing this! 🚀
toshimaru
added a commit
to toshimaru/RailsTwitterClone
that referenced
this pull request
May 15, 2024
toshimaru
added a commit
to toshimaru/RailsTwitterClone
that referenced
this pull request
May 15, 2024
* build(deps-dev): Bump faker from 3.2.3 to 3.3.1 Bumps [faker](https://github.com/faker-ruby/faker) from 3.2.3 to 3.3.1. - [Release notes](https://github.com/faker-ruby/faker/releases) - [Changelog](https://github.com/faker-ruby/faker/blob/main/CHANGELOG.md) - [Commits](faker-ruby/faker@v3.2.3...v3.3.1) --- updated-dependencies: - dependency-name: faker dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * fix: Use `Faker::Internet.email` instead of `free_email` ## Related PR - faker-ruby/faker#2733 - faker-ruby/faker#2841 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Toshimaru <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
FYI: #2733
The
safe_emailandfree_emailmethods are slated for deprecation in October 2023. Therefore, they are being removed in this pull request.Additional information
bundle exec rake test
bundle exec rubocop
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator: