upgrade go version and add more idiomatic Go#61
Open
hilaryRope wants to merge 7 commits into
Open
Conversation
hilaryRope
force-pushed
the
more-idiomatic-go
branch
from
5789d48 to
31dc4bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #62
Go PDK Fixes
Version Alignment (Go 1.23)
go.modgo 1.21.1→go 1.23go.workgo 1.21.1→go 1.23wasi-reactor/go.modgo 1.21.1→go 1.23Idiomatic Go 1.22+ Updates
extism_pdk.go
for i := 0; i < n; i++withfor i := range nmake([]byte, 8)+PutUint64withAppendUint64(nil, ...)Idiomatic Improvements
extism_pdk.go
LogTracecase to LogLevel.String()memory→memin Send() to avoid shadowing package(HTTPResponse, error)[]byte{}→nilinAppendUint32/64callsclengthin Output(), usem.Length()directlybody: nilin NewHTTPRequestkey, value stringTypo Fixes
example/countvowels/std_main.goCountVowelsOuptut→CountVowelsOutputexample/countvowels/tiny_main.goCountVowelsOuptut→CountVowelsOutputexample/http/std_main.gowithuot→withoutunmartialed→unmarshaledCode Cleanup
default:cases in switch statements (std_main.go,tiny_main.go)