feat/fix/chore: various improvements#16
Merged
Merged
Conversation
manifest - serialize the header value correctly current_plugin - when outputting, check against output range correctly
…tional is sufficient to check if an item is empty
…uctor. prevents copying Plugin
…ring to items in native memory
…ove and std::string_view cleanup
zshipko
approved these changes
Dec 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #14
feat:
Plugin::resetWasmSourceBytesfix:
chore:
ManifestKey, the stl containers andstd::optionalare sufficientstd::unique_ptrto more safely managePlugin'sExtismPluginlifetimestd::stringno longer required for plugin calls. The duplication introduced can be removed withstd::string_viewif sdk: consider switching away from null terminated strings to ptr and length extism#646 is accepted and implementedsize_tinstead ofExtismSizewhen referring to items in native memory / not using libextism