Skip to content

Sphinx py3#309

Merged
ddemidov merged 4 commits intoev3dev:developfrom
EricPobot:sphinx_py3
Feb 18, 2017
Merged

Sphinx py3#309
ddemidov merged 4 commits intoev3dev:developfrom
EricPobot:sphinx_py3

Conversation

@EricPobot
Copy link
Copy Markdown
Contributor

workaround for building the Sphinx doc on environments with Python2 as default interpreter

@EricPobot
Copy link
Copy Markdown
Contributor Author

@ddemidov I may have done something wrong with branches since the commits related to previous changes (private tables in Sound) are visible here. I don't know if this breaks something.

@ddemidov
Copy link
Copy Markdown
Member

I think you forgot to git pull while on develop branch before checking out the new branch. The following commands (while on sphinx_py3 branch) should fix this:

git fetch origin  # fetch the latest changes from upstream
git reset --hard origin/develop # reset the branch to origin/develop
git cherry-pick 61d62f883659c65db271a4f5afdbd36f45924596 # pick the one commit that matters (it will still be in local cache)
git push -f # push the branch to your fork, overwriting its history

@ddemidov
Copy link
Copy Markdown
Member

And by the way, I can confirm this still works on Arch linux.

@ddemidov
Copy link
Copy Markdown
Member

In fact, I think that github's 'squash and merge' should be enough in this case.

@ddemidov ddemidov merged commit 1e5c835 into ev3dev:develop Feb 18, 2017
@ddemidov
Copy link
Copy Markdown
Member

Thanks! And do not forget to update your develop branch before making new changes 😏

@EricPobot
Copy link
Copy Markdown
Contributor Author

EricPobot commented Feb 18, 2017

Thanks for advanced Git lesson 😉

What happened is that I made the sphinx3 changes while working on the Sound class updates, to be able to check the generated documentation. But I did not want to include these changes with the source code modifications, since they were not really related.

What I should have done is including them in the change tracking only after the Sound class modifications merge. This way they would have appeared in their own "sprint".

@EricPobot EricPobot deleted the sphinx_py3 branch February 18, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants