feat: update complexity rule to only highlight function header (#20048)

Un5had0wed · web-flow · commit ce40f74efd45 · 2025-10-16T16:53:40.000-04:00
* feat: adjust highlighting to minimize visual noise for the 'complexity' rule Fixes #19984 * Add new test
diff --git a/lib/rules/complexity.js b/lib/rules/complexity.js
@@ -171,17 +171,23 @@ module.exports = {
 
 				if (complexity > threshold) {
 					let name;
+					let loc = node.loc;
 
 					if (codePath.origin === "class-field-initializer") {
 						name = "class field initializer";
 					} else if (codePath.origin === "class-static-block") {
 						name = "class static block";
 					} else {
 						name = astUtils.getFunctionNameWithKind(node);
+						loc = astUtils.getFunctionHeadLoc(
+							node,
+							context.sourceCode,
+						);
 					}
 
 					context.report({
 						node,
+						loc,
 						messageId: "complex",
 						data: {
 							name: upperCaseFirst(name),
diff --git a/tests/lib/rules/complexity.js b/tests/lib/rules/complexity.js
@@ -318,6 +318,17 @@ ruleTester.run("complexity", rule, {
 			options: [0],
 			errors: [makeError("Function 'a'", 1, 0)],
 		},
+		{
+			code: "function foo(x) {if (x > 10) {return 'x is greater than 10';} else if (x > 5) {return 'x is greater than 5';} else {return 'x is less than 5';}}",
+			options: [2],
+			errors: [
+				{
+					...makeError("Function 'foo'", 3, 2),
+					column: 1,
+					endColumn: 13,
+				},
+			],
+		},
 		{
 			code: "var func = function () {}",
 			options: [0],
@@ -827,13 +838,38 @@ ruleTester.run("complexity", rule, {
 				},
 			],
 		},
+		{
+			code: "class C { x = () => a || b || c; y = f || g || h; }",
+			options: [2],
+			languageOptions: { ecmaVersion: 2022 },
+			errors: [
+				{
+					...makeError("Method 'x'", 3, 2),
+					column: 11,
+					endColumn: 15,
+				},
+				{
+					...makeError("Class field initializer", 3, 2),
+					column: 38,
+					endColumn: 49,
+				},
+			],
+		},
 
 		// object property options
 		{
 			code: "function a(x) {}",
 			options: [{ max: 0 }],
 			errors: [makeError("Function 'a'", 1, 0)],
 		},
+		{
+			code: "const obj = { b: (a) => a?.b?.c, c: function (a) { return a?.b?.c; } };",
+			options: [{ max: 2 }],
+			errors: [
+				{ ...makeError("Method 'b'", 3, 2), column: 15, endColumn: 18 },
+				{ ...makeError("Method 'c'", 3, 2), column: 34, endColumn: 46 },
+			],
+		},
 
 		// optional chaining
 		{
@@ -869,7 +905,13 @@ ruleTester.run("complexity", rule, {
 		{
 			code: "function a(b) { b?.c.d?.e; }",
 			options: [{ max: 2 }],
-			errors: [makeError("Function 'a'", 3, 2)],
+			errors: [
+				{
+					...makeError("Function 'a'", 3, 2),
+					column: 1,
+					endColumn: 11,
+				},
+			],
 		},
 		{
 			code: "function a(b) { b?.c?.(); }",
