Skip to content

Misc console fixes for long-standing bugs#327

Merged
jmmv merged 4 commits into
masterfrom
fixes
Jun 9, 2026
Merged

Misc console fixes for long-standing bugs#327
jmmv merged 4 commits into
masterfrom
fixes

Conversation

@jmmv

@jmmv jmmv commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

jmmv added 4 commits June 9, 2026 07:00
The previous commit to test the bucket-fill operations added pixel
state tracking to test helpers.  I used a Vec because it seemed OK
for the new tests... but I didn't pay enough attention to notice
that this made a couple of existing tests very slow.

Fix this by moving the pixel tracking to a HashMap.
Render the pager's continuation prompt with whatever colors are
already active instead of forcing the console defaults.

While here, add a TODO to document the existing set_color
None-value mismatch with actual behavior, as I spotted this
while fixing the pager issue.
Limit text scrolling to the rows that actually belong to the character
grid so partial bottom margins cannot leak into the last line.

This fixes an oddity I had been observing for a while where the last
line was only half-colored.
Honor the raster scrolling contract by repainting the newly exposed
portion of the source area after shifting the canvas contents upward.

This is related to the previous commit and ensures that new lines are
drawn with the correct background color, and that running CLS causes
the whole screen to be "blanked" with the new background color.
@jmmv jmmv changed the title Misc conosle fixes for long-standing bugs Misc console fixes for long-standing bugs Jun 9, 2026
@jmmv jmmv merged commit 83dff07 into master Jun 9, 2026
12 checks passed
@jmmv jmmv deleted the fixes branch June 9, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant