Conversation
The previous commit to test the bucket-fill operations added pixel state tracking to test helpers. I used a Vec because it seemed OK for the new tests... but I didn't pay enough attention to notice that this made a couple of existing tests very slow. Fix this by moving the pixel tracking to a HashMap.
Render the pager's continuation prompt with whatever colors are already active instead of forcing the console defaults. While here, add a TODO to document the existing set_color None-value mismatch with actual behavior, as I spotted this while fixing the pager issue.
Limit text scrolling to the rows that actually belong to the character grid so partial bottom margins cannot leak into the last line. This fixes an oddity I had been observing for a while where the last line was only half-colored.
Honor the raster scrolling contract by repainting the newly exposed portion of the source area after shifting the canvas contents upward. This is related to the previous commit and ensures that new lines are drawn with the correct background color, and that running CLS causes the whole screen to be "blanked" with the new background color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.