Skip to content

Add support for TLS imports/exports to/from DSOs - #14971

Merged
sbc100 merged 1 commit into
mainfrom
tls_dso_export
Sep 17, 2021
Merged

Add support for TLS imports/exports to/from DSOs#14971
sbc100 merged 1 commit into
mainfrom
tls_dso_export

Conversation

@sbc100

@sbc100 sbc100 commented Aug 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This change is based on the recently added EXPORT_INFO metadata that tells
the dynamic linker which exports are TLS exports and which are normal data
exports: https://reviews.llvm.org/D108877

@sbc100 sbc100 changed the title WIP: Inter-module TLS support Inter-module TLS support Sep 15, 2021
@sbc100 sbc100 changed the title Inter-module TLS support ]Add support for TLS imports/exports to/from DSOs Sep 15, 2021
@sbc100 sbc100 changed the title ]Add support for TLS imports/exports to/from DSOs Add support for TLS imports/exports to/from DSOs Sep 15, 2021
@sbc100
sbc100 requested review from dschuff and kripken September 15, 2021 13:10
@sbc100
sbc100 force-pushed the tls_dso_export branch 2 times, most recently from 4840a56 to a5ec6ba Compare September 16, 2021 15:03
@sbc100

sbc100 commented Sep 16, 2021

Copy link
Copy Markdown
Collaborator Author

All tests now passing. ptal

kripken
kripken reviewed Sep 16, 2021
View reviewed changes

@kripken kripken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a deep understanding of the TLS side of things here. But looks good otherwise at a high level, aside from comments.

Comment thread src/library_pthread.js Outdated
Comment thread src/library_pthread.js
dschuff
dschuff approved these changes Sep 16, 2021
View reviewed changes
Comment thread src/library_pthread.js Outdated
@sbc100
Add support for TLS imports/exports to/from DSOs
d7908c1 
This change is based on the recently added EXPORT_INFO metadata that tells
the dynamic linker which exports are TLS exports and which are normal data
exports: https://reviews.llvm.org/D108877
@sbc100
sbc100 enabled auto-merge (squash) September 16, 2021 22:39
@sbc100
sbc100 merged commit 06dcec6 into main Sep 17, 2021
@sbc100
sbc100 deleted the tls_dso_export branch September 17, 2021 00:40
sbc100 added a commit that referenced this pull request Oct 25, 2021
@sbc100
Enable longjmp + pthreads + dylink
c7aa5c8 
The underlying bug that caused this configuration
not to work (lack of TLS import/export) was fixed
in #14971.

Fixes: #14461
@sbc100 sbc100 mentioned this pull request Oct 25, 2021
Merged
sbc100 added a commit that referenced this pull request Oct 26, 2021
@sbc100
Enable longjmp + pthreads + dylink
187c744 
The underlying bug that caused this configuration
not to work (lack of TLS import/export) was fixed
in #14971.

Fixes: #14461
sbc100 added a commit that referenced this pull request Oct 26, 2021
@sbc100
Enable longjmp + pthreads + dylink
0dbbb0d 
The underlying bug that caused this configuration
not to work (lack of TLS import/export) was fixed
in #14971.

Fixes: #14461
sbc100 added a commit that referenced this pull request Oct 26, 2021
@sbc100
Enable longjmp + pthreads + dylink (#15356)
3ba93f0 
The underlying bug that caused this configuration
not to work (lack of TLS import/export) was fixed
in #14971.

Fixes: #14461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kripken kripken kripken approved these changes
@dschuff dschuff dschuff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbc100 @kripken @dschuff