Small feature: Service Matcher on Embed.ly Client#2
Closed
umbrae wants to merge 3 commits intoembedly:masterfrom
Closed
Small feature: Service Matcher on Embed.ly Client#2umbrae wants to merge 3 commits intoembedly:masterfrom
umbrae wants to merge 3 commits intoembedly:masterfrom
Conversation
…e if a URL is serviced by embed.ly or not
Conflicts: embedly/client.py
Author
|
Updated to match the new version of the library. I assume you guys aren't going to use this at this point, but I'll leave it open in case anyone else stumbles upon it or you have feedback. |
Contributor
|
Hi, I added your changes, but changed the method name and the way that the regex method worked:051feb1#L2R69 You can now do Thanks for the pull request and bearing with us while we got to fixing it. Sean |
Author
|
Sounds good, thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a service matcher to the python client - allows you to determine if a URL is serviced by embed.ly or not. I think this is a similar approach to what reddit uses, except theirs is hardcoded.
In my own implementation I've also added a caching layer to get_services, which I think will be pretty important for speed, but isn't very implementation-agnostic just yet.
Not sure if this uses the same sort of internal lingo you guys might use at embed.ly - feel free to edit.