Skip to content

chore: bump node to v12.16.1 (master)#22168

Merged
codebytere merged 33 commits intomasterfrom
roller/node/master
Feb 24, 2020
Merged

chore: bump node to v12.16.1 (master)#22168
codebytere merged 33 commits intomasterfrom
roller/node/master

Conversation

@electron-bot
Copy link
Contributor

@electron-bot electron-bot commented Feb 12, 2020

Updating Node.js to v12.16.0.

See all changes in v12.15.0..v12.16.0

Notes: Updated Node.js to v12.16.0.

@electron-bot electron-bot requested a review from a team as a code owner February 12, 2020 13:00
@codebytere codebytere self-assigned this Feb 12, 2020
@codebytere codebytere force-pushed the roller/node/master branch 8 times, most recently from 7bd3d1a to 9cab619 Compare February 13, 2020 19:08
ckerr
ckerr previously approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers. A couple of questions, but overall looks nice.

I hadn't looked at uvwasi before, that's pretty cool 😎

@ckerr ckerr dismissed their stale review February 14, 2020 20:57

ope; I didn't notice the CI runs and incorrectly thought this was ready to go. Sorry for the premature approve

@codebytere codebytere force-pushed the roller/node/master branch 11 times, most recently from 10f8184 to 590ecb0 Compare February 21, 2020 03:41
@codebytere codebytere changed the title chore: bump node to v12.16.0 (master) chore: bump node to v12.16.1 (master) Feb 21, 2020
@codebytere codebytere force-pushed the roller/node/master branch 5 times, most recently from 76abe85 to e43d713 Compare February 24, 2020 04:03
@codebytere
Remove redundant cli flag patch
25d4d0d 
nodejs/node#30466
@codebytere
Update filenames.json
5593079
@codebytere
Remove macro generation in GN build files
1eff31e 
nodejs/node#30755
@codebytere
Fix some compilation errors upstream
86107b4
@codebytere
Add uvwasi to deps
09e980f 
nodejs/node#30258
@codebytere
Fix BoringSSL incompatibilities
0abef39
@codebytere
Fixup linked module patch
4ebd553 
nodejs/node#30274
@codebytere
Add missing sources to GN uv build
79f6df4 
libuv/libuv#2347
@codebytere
Patch some uvwasi incompatibilities
beaee05
@codebytere
chore: bump Node.js to v12.6.1
6c13c19
@codebytere
Remove mark_arraybuffer_as_untransferable.patch
5900b52 
nodejs/node#30549
@codebytere
Fix uvwasi build failure on win
745f2bf
@codebytere
Fixup --perf-prof cli option error
bcd930e
@codebytere
Fixup early cjs module loading
fd27c63
@codebytere
fix: initialize diagnostics properly
42be329 
nodejs/node#30025
@codebytere
Disable new esm syntax specs
f50ef63 
nodejs/node#30219
@codebytere
Fixup v8 weakref hook spec
fee8d72 
nodejs/node#29874
@codebytere
Fix async context timer issue
c37dc47
@codebytere
Disable monkey-patch-main spec
7215b31 
It relies on nodejs/node#29777, and we don't
override prepareStackTrace.
@codebytere
Disable new tls specs
43e4324 
nodejs/node#23188

We don't support much of TLS owing to schisms between BoringSSL and
OpenSSL.
ckerr
ckerr reviewed Feb 24, 2020
View reviewed changes
MarshallOfSound
MarshallOfSound approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoping we can upstream as much of this work and the new patches as possible

@codebytere
Copy link
Member

codebytere commented Feb 24, 2020

@MarshallOfSound of the added patches:

fix_use_hex_not_decimal_for_clarity.patch
fix_use_crypto_impls_for_compat.patch
fix_ensure_clocks_header_included_in_impl.patch
fix_remove_implicit_type_conversions.patch
fix_include_io_h_in_uvwasi_for_win.patch
fix_--perf-prof_only_works_on_linux.patch
fix_we_need_to_eager-load_cjs_modules.patch

all except fix_we_need_to_eager-load_cjs_modules.patch have already been upstreamed and merged :)

@codebytere codebytere merged commit f965b13 into master Feb 24, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 24, 2020

Release Notes Persisted

Updated Node.js to v12.16.0.

@codebytere codebytere deleted the roller/node/master branch February 24, 2020 21:02
deepak1556
deepak1556 reviewed Feb 24, 2020
View reviewed changes
shell/app/node_main.cc
node::InternalCallbackScope callback_scope(
env, v8::Local<v8::Object>(), {1, 0},
node::InternalCallbackScope::kAllowEmptyResource |
node::InternalCallbackScope::kSkipAsyncHooks);
Copy link
Member

@deepak1556 deepak1556 Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it recommended to skip async hooks in callback scope ? In that case should we also do that for our node integration https://github.com/electron/electron/blob/master/shell/common/api/electron_bindings.cc#L136 ?

Copy link
Member

@deepak1556 deepak1556 Feb 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @codebytere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepak1556 deepak1556 deepak1556 left review comments

@codebytere codebytere codebytere left review comments

@ckerr ckerr ckerr approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

@codebytere codebytere

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@electron-bot @codebytere @ckerr @deepak1556 @MarshallOfSound