test: fix failing iframe test

codebytere · codebytere · commit 4eedea620ff5 · 2021-06-03T00:02:52.000+02:00
nodejs/node#33021
diff --git a/spec-main/api-browser-window-spec.ts b/spec-main/api-browser-window-spec.ts
@@ -3660,11 +3660,12 @@ describe('BrowserWindow module', () => {
         expect(w.webContents.isLoadingMainFrame()).to.be.false('isLoadingMainFrame');
 
         const didStartLoading = emittedOnce(w.webContents, 'did-start-loading');
-        w.webContents.executeJavaScript(`
+        await w.webContents.executeJavaScript(`(() => {
           var iframe = document.createElement('iframe')
           iframe.src = '${serverUrl}/page2'
           document.body.appendChild(iframe)
-        `);
+          return null
+        })()`);
         await didStartLoading;
 
         expect(w.webContents.isLoadingMainFrame()).to.be.false('isLoadingMainFrame');
