fix(sync-service): Fix KeyError due to explicit type casts on WHERE clause parameters #3687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3687 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 23 23
Lines 1898 1898
Branches 499 502 +3
=======================================
Hits 1669 1669
Misses 227 227
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
…RE clause parameters Preserve param_ref metadata in infer_unknown and explicit_cast_const so parameters like $1::text can be resolved during query rebuilding. Fixes #3686
magnetised
force-pushed
the
magnetised/issue-3686-keyerror
branch
from
11641a4 to
636bcbe
Compare
robacourt
approved these changes
Jan 8, 2026
Contributor
|
This PR has been released! 🚀 The following packages include changes from this PR:
Thanks for contributing to Electric! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve param_ref metadata in infer_unknown and explicit_cast_const so parameters like $1::text can be resolved during query rebuilding.
Fixes #3686