Skip to content

fix(awsutil): let SkipRegionalForGlobalService honor explicit aws-global clients #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chadwpetersen wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(awsutil): let SkipRegionalForGlobalService honor explicit aws-global clients #984

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e007ffd
fix(cloudformation-stack): allow CreateRole on regional configs
chadwpetersen Jun 23, 2026
2a8cc57
fix(awsutil): let SkipRegionalForGlobalService honor explicit aws-glo…
chadwpetersen Jun 25, 2026
a8afcfa
docs(awsutil): document the aws-global escape hatch on SkipRegionalFo…
chadwpetersen Jun 25, 2026
674e025
Remove inline comments on IAM client construction
chadwpetersen Jun 25, 2026
77d8b2c
Add brief pointer comment at IAM client call sites
chadwpetersen Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add brief pointer comment at IAM client call sites
  • Loading branch information
@chadwpetersen
chadwpetersen committed Jun 25, 2026
commit 77d8b2c0f04898a3701adc9b3524689a990c47a3
1 change: 1 addition & 0 deletions resources/cloudformation-stack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ func (l *CloudFormationStackLister) List(_ context.Context, o interface{}) ([]re
opts := o.(*nuke.ListerOpts)

svc := cloudformation.New(opts.Session)
// Pinned to aws-global; see awsutil.SkipRegionalForGlobalService.
iamSvc := iam.NewFromConfig(*opts.Config, func(o *iam.Options) {
o.Region = "aws-global"
})
Expand Down
1 change: 1 addition & 0 deletions resources/ssmquicksetup-configuration-manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ func (l *SSMQuickSetupConfigurationManagerLister) List(ctx context.Context, o in
for _, p := range res.ConfigurationManagersList {
resources = append(resources, &SSMQuickSetupConfigurationManager{
svc: svc,
// Pinned to aws-global; see awsutil.SkipRegionalForGlobalService.
iamSvc: iam.NewFromConfig(*opts.Config, func(o *iam.Options) {
o.Region = "aws-global"
}),
Expand Down
Loading