fix(awsutil): let SkipRegionalForGlobalService honor explicit aws-global clients - #984
Open
chadwpetersen wants to merge 5 commits into
Open
chadwpetersen wants to merge 5 commits into
chadwpetersen wants to merge 5 commits into
Conversation
Pin the IAM client built in CloudFormationStackLister to aws-global and strip the SkipRegionalForGlobalService middleware that NewConfig attaches to every regional config. Without this, the CreateRoleToDeleteStack recovery path is refused by ekristen's own middleware with "service 'IAM' is global, but the session is not", leaving stacks with a stale RoleARN stuck in DELETE_FAILED forever.
…bal clients Move the workaround for global-service calls from a regional context into the middleware itself: clients explicitly built with Region="aws-global" pass through. Accidental misuse (no region override) is still blocked with the original error message. This collapses the bespoke workaround in cloudformation-stack.go and covers ssmquicksetup-configuration-manager.go, which had the identical bug for its CreateRoleToDelete recovery path. Resources that legitimately need IAM from a regional scanner now just set o.Region = "aws-global" on the client — no APIOptions surgery.
chadwpetersen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateRoleToDeleteStack(CloudFormationStack) andCreateRoleToDelete(SSMQuickSetupConfigurationManager) both build an IAM client from the regionalopts.Configand calliam.CreateRoleto recreate a missing role. TheSkipRegionalForGlobalServicemiddleware thatNewConfigattaches to every regional config refuses these calls:Move the workaround into the middleware itself: clients explicitly built with
Region = "aws-global"pass through. Accidental misuse (no region override) is still blocked with the original error.Resources that legitimately need IAM from a regional scanner can now just set
o.Region = "aws-global"on the client.