Skip to content

Export function instead of its returned value #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
m-kusnierz wants to merge 1 commit into from
Closed

Export function instead of its returned value #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Bump moduleconfig 
Breaking change: export function instead of value returned from it to avoid caching the value
  • Loading branch information
@m-kusnierz
m-kusnierz committed Aug 16, 2023
commit ee4851677d0e280d8a5f15ef624a32de259e549e
2 changes: 1 addition & 1 deletion lib/middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"use strict";
module.exports = function(options){

var errors = require("nodeerrors");
var errors = require("nodeerrors")();
return errorHandler;

function errorHandler(err, req, res, next){
Expand Down
7 changes: 5 additions & 2 deletions lib/nodeerrors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
"use strict";
var parentModule = require('parent-module');
var path = require('path');
var getErrorConfig = require("./util/getErrorConfig");
var makeErrorFunction = require("./util/makeErrorFunction");
var moduleConfig = require("moduleconfig");
Expand Down Expand Up @@ -29,8 +31,9 @@ function getNodeErrors() {
};
}

var startDir = path.dirname(parentModule());

return moduleConfig([".errors.js", "config/.errors.js"], function(errorConfigFilePath){
return moduleConfig(startDir, [".errors.js", "config/.errors.js"], function(errorConfigFilePath) {
//Not in cache, create nodeErrors object
var nodeError = {
errorCodes:{},
Expand All @@ -52,4 +55,4 @@ function getNodeErrors() {

}

module.exports = getNodeErrors();
module.exports = getNodeErrors;
Loading