Merged
Conversation
# Conflicts: # src/common/odbc_utils.cpp # src/empty_stubs.cpp # src/statement/statement.cpp # test/CMakeLists.txt
maiadegraaf
force-pushed
the
empty_stubs_improvements
branch
from
8ea5fe0 to
abc637f
Compare
staticlibs
approved these changes
May 10, 2025
Collaborator
staticlibs
left a comment
staticlibs
left a comment
There was a problem hiding this comment.
Nice cleanup of this part and great test coverage! I've added a few minor things in inline comments.
| } | ||
|
|
||
| return SetNotImplemented(hdl, "SQLBrowseConnect"); | ||
| } |
Collaborator
There was a problem hiding this comment.
Can we add a SQLBrowseConnectW counterpart to this function? It is included in the list of Unicode ODBC functions. We are not planning to implement it, so this is just for consistency.
Collaborator
Author
There was a problem hiding this comment.
Good catch. I've added it as well as a test for it.
Minor type casting and consistency updates.
# Conflicts: # test/CMakeLists.txt
maiadegraaf
force-pushed
the
empty_stubs_improvements
branch
from
77d0529 to
d7eda0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the implementation of the empty stub functions to either set an empty response or a diagnostic record.
Empty Results:
SQLPrimaryKeysSQLForeignKeysSQLProcedureColumnsSQLProceduresSQLColumnPrivilegesSQLTablePrivilegesSQLSpecialColumnsSQLStatisticsReturns Error with diagnostics
SQLNativeSqlSQLBrowseConnectSQLBulkOperationsSQLSetPosSQLSpecialColumnsandSQLStatisticswere previously implemented with empty results and moved tostatement.cppbut have now been pushed back toempty_stubs.cppto keep all the functions with empty results together.