Enable runtime-async for System.IO.Compression, System.IO.Compression.Brotli, and System.Net.WebSockets by Copilot · Pull Request #124397 · dotnet/runtime

Copilot · 2026-02-13T18:44:01Z

Description

Enables the runtime-async compiler feature on the System.IO.Compression, System.IO.Compression.Brotli, and System.Net.WebSockets source libraries to allow performance testing of runtime-async with compression and WebSocket workloads.

Adds <Features>$(Features);runtime-async=on</Features> with NoWarn CA2252 suppression to all three library csproj files
Guards enablement with conditions matching eng/testing/tests.targets: excluded for browser, wasi, and Mono targets where runtime-async is unsupported
Uses NoWarn CA2252 instead of EnablePreviewFeatures to avoid propagating [assembly: RequiresPreviewFeatures] to downstream type-forwarding shim assemblies (e.g., the System shim)

All existing tests pass (1400 System.IO.Compression, 328 Brotli, 570 System.Net.WebSockets). Full clr+libs build succeeds with 0 warnings and 0 errors.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ion.Brotli Co-authored-by: agocke <[email protected]>

dotnet-policy-service · 2026-02-13T19:23:29Z

Tagging subscribers to this area: @karelz, @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

agocke · 2026-02-13T19:33:42Z

/benchmark

pr-benchmarks · 2026-02-13T19:34:01Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation

Profiles:

aspnet-citrine-ampere: Ampere/Linux 80 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T19:45:53Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation
httpclient: HttpClient Benchmark (change HTTP version by adding e.g. --variable httpVersion=3.0; change response size by adding e.g. --variable responseSize=256; default: HTTP/1.1 GET 8K)

Profiles:

aspnet-perf-win: Intel/Windows 12 Cores
aspnet-citrine-win: Intel/Windows 28 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T19:46:03Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation

Profiles:

aspnet-citrine-win-ampere: Ampere/Windows 80 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

agocke · 2026-02-13T20:08:11Z

/benchmark micro

pr-benchmarks · 2026-02-13T20:11:03Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation
httpclient: HttpClient Benchmark (change HTTP version by adding e.g. --variable httpVersion=3.0; change response size by adding e.g. --variable responseSize=256; default: HTTP/1.1 GET 8K)

Profiles:

aspnet-perf-win: Intel/Windows 12 Cores
aspnet-citrine-win: Intel/Windows 28 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T20:11:13Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation

Profiles:

aspnet-citrine-win-ampere: Ampere/Windows 80 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T20:14:26Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation
httpclient: HttpClient Benchmark (change HTTP version by adding e.g. --variable httpVersion=3.0; change response size by adding e.g. --variable responseSize=256; default: HTTP/1.1 GET 8K)

Profiles:

aspnet-citrine-lin: Intel/Linux 28 Cores
aspnet-perf-lin: Intel/Linux 12 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T20:14:33Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation

Profiles:

aspnet-citrine-ampere: Ampere/Linux 80 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

agocke · 2026-02-13T20:15:53Z

/benchmark micro libs

pr-benchmarks · 2026-02-13T20:33:27Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation
httpclient: HttpClient Benchmark (change HTTP version by adding e.g. --variable httpVersion=3.0; change response size by adding e.g. --variable responseSize=256; default: HTTP/1.1 GET 8K)

Profiles:

aspnet-citrine-lin: Intel/Linux 28 Cores
aspnet-perf-lin: Intel/Linux 12 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T20:33:35Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation

Profiles:

aspnet-citrine-ampere: Ampere/Linux 80 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T20:43:58Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation
httpclient: HttpClient Benchmark (change HTTP version by adding e.g. --variable httpVersion=3.0; change response size by adding e.g. --variable responseSize=256; default: HTTP/1.1 GET 8K)

Profiles:

aspnet-perf-win: Intel/Windows 12 Cores
aspnet-citrine-win: Intel/Windows 28 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T20:44:07Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation

Profiles:

aspnet-citrine-win-ampere: Ampere/Windows 80 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

agocke · 2026-02-13T23:04:32Z

/benchmark micro aspnet-perf-lin libs

pr-benchmarks · 2026-02-13T23:13:59Z

Benchmark started for micro on aspnet-perf-lin with libs. Logs: link

pr-benchmarks · 2026-02-13T23:16:43Z

An error occurred, please check the logs

agocke · 2026-02-13T23:46:26Z

@copilot please also enable preview features for System.Net.WebSockets

…ropagation for all three libraries Co-authored-by: agocke <[email protected]>

Copilot · 2026-02-14T00:22:10Z

@copilot please also enable preview features for System.Net.WebSockets

Done in 06236ed. Also fixed all three libraries to use NoWarn CA2252 instead of EnablePreviewFeatures — the latter was generating [assembly: RequiresPreviewFeatures] which broke the System type-forwarding shim. All 570 WebSockets tests pass.

Initial plan

610dfe0

Copilot AI assigned Copilot and agocke Feb 13, 2026

github-project-automation bot added this to AppModel Feb 13, 2026

Copilot started work on behalf of agocke February 13, 2026 18:44 View session

jkotas added the runtime-async label Feb 13, 2026

github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 13, 2026

Enable runtime-async for System.IO.Compression and System.IO.Compress…

22e14cf

…ion.Brotli Co-authored-by: agocke <[email protected]>

Copilot AI changed the title ~~[WIP] Enable runtime async for System.Compression performance testing~~ Enable runtime-async for System.IO.Compression and System.IO.Compression.Brotli Feb 13, 2026

Copilot AI requested a review from agocke February 13, 2026 19:17

Copilot finished work on behalf of agocke February 13, 2026 19:17

github-actions bot added area-System.IO.Compression and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 13, 2026

Copilot AI mentioned this pull request Feb 13, 2026

[WIP] Open new version of PR with applied feedback #124406

Closed

5 tasks

Copilot started work on behalf of agocke February 13, 2026 23:46 View session

Enable runtime-async for System.Net.WebSockets; fix preview feature p…

06236ed

…ropagation for all three libraries Co-authored-by: agocke <[email protected]>

Copilot AI changed the title ~~Enable runtime-async for System.IO.Compression and System.IO.Compression.Brotli~~ Enable runtime-async for System.IO.Compression, System.IO.Compression.Brotli, and System.Net.WebSockets Feb 14, 2026

Copilot finished work on behalf of agocke February 14, 2026 00:22

build-analysis bot mentioned this pull request Feb 14, 2026

Sometimes the helix SDK uses GetWorkItemsAsync when workitems aren't done processing. dotnet/dnceng#6011

Open

3 tasks

Conversation

Copilot AI commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

dotnet-policy-service bot commented Feb 13, 2026

Uh oh!

agocke commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

agocke commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

agocke commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

agocke commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

agocke commented Feb 13, 2026

Uh oh!

Copilot AI commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 13, 2026 •

edited

Loading