Skip to content

Fix timeout/duration calculations using monotonic time and precise tick accumulation #123980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 4 commits into from
Feb 4, 2026
Merged

Fix timeout/duration calculations using monotonic time and precise tick accumulation #123980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f460b5
Initial plan
Copilot Feb 4, 2026
5cf9826
Fix .Milliseconds to .TotalMilliseconds in timeout and duration calcu…
Copilot Feb 4, 2026
130124c
Use Stopwatch for monotonic timing and Ticks for precise duration
Copilot Feb 4, 2026
1390e39
Rename totalTicks to totalDurationTicks for clarity
Copilot Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncContext.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1388,7 +1388,7 @@ private void PerformSyncOperation<TOperation>(ref OperationQueue<TOperation> que
bool timeoutExpired = false;
while (true)
{
DateTime waitStart = DateTime.UtcNow;
long waitStart = Stopwatch.GetTimestamp();

if (!e.Wait(timeout))
{
Expand All @@ -1411,7 +1411,7 @@ private void PerformSyncOperation<TOperation>(ref OperationQueue<TOperation> que
// Adjust timeout and try again.
if (timeout > 0)
{
timeout -= (DateTime.UtcNow - waitStart).Milliseconds;
timeout -= (int)Stopwatch.GetElapsedTime(waitStart).TotalMilliseconds;

if (timeout <= 0)
{
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/System.Speech/src/Internal/Synthesis/EngineSite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,17 +480,17 @@ private void ConvertCompleteUnit()
// Retain any other information based on the first TTS phoneme event.
//
TTSEvent ttsEvent, targetEvent, basePhonemeEvent = null;
long totalDuration = 0;
long totalDurationTicks = 0;
basePhonemeEvent = (TTSEvent)_phonemeQueue.Peek();
for (int i = 0; i < _lastComplete;)
{
ttsEvent = (TTSEvent)_phonemeQueue.Dequeue();
totalDuration += ttsEvent.PhonemeDuration.Milliseconds;
totalDurationTicks += ttsEvent.PhonemeDuration.Ticks;
i += ttsEvent.Phoneme.Length;
}

targetEvent = TTSEvent.CreatePhonemeEvent(new string(target), "",
TimeSpan.FromMilliseconds(totalDuration),
TimeSpan.FromTicks(totalDurationTicks),
basePhonemeEvent.PhonemeEmphasis,
basePhonemeEvent.Prompt,
basePhonemeEvent.AudioPosition);
Expand Down
Loading