Sync area notification subscribers with area-owners.md#122357
Conversation
Update resourceManagement.yml to match area-owners.md for area-AssemblyLoader-coreclr. The mentionees are now @agocke and @elinor-fung, matching the owners listed in area-owners.md. Co-authored-by: agocke <[email protected]>
Updated resourceManagement.yml to sync all area label notification subscribers with docs/area-owners.md. Key changes: - area-Host: vitek-karas, agocke, vsadov -> jeffschwMSFT, elinor-fung - area-HostModel: vitek-karas, agocke -> elinor-fung - area-AssemblyLoader-mono: [] -> agocke, elinor-fung - area-CodeGen-coreclr: JulieLeeMSFT, jakobbotsch -> dotnet/jit-contrib - area-GC-coreclr: dotnet/gc -> Maoni0 - area-Infrastructure: dotnet/runtime-infrastructure -> jeffschwMSFT, MichaelSimons - And 27 other areas synced with their documented owners Total: 33 areas updated to match area-owners.md Co-authored-by: agocke <[email protected]>
Updated resourceManagement.yml to include both the Lead and Owners columns from area-owners.md in notification subscribers, as requested. Previously only included Owners column, now includes Lead + Owners (with Lead first if not already in Owners list). Key examples: - area-Codegen-Intrinsics-mono: [] -> steveisok (Lead only, no owners) - area-Build-mono: akoeplinger -> lewing, akoeplinger (added Lead) - area-Host: jeffschwMSFT, elinor-fung -> agocke, jeffschwMSFT, elinor-fung (added Lead) - area-GC-coreclr: Maoni0 -> agocke, Maoni0 (added Lead) - And 92 other areas updated to include Lead Total: 96 areas updated to include both Lead and Owners Co-authored-by: agocke <[email protected]>
Updated area-owners.md to correct the Owners for area-GC-coreclr from @Maoni0 to @dotnet/gc. Also updated resourceManagement.yml to match the corrected area-owners.md. This ensures the GC team is notified for area-GC-coreclr issues rather than just an individual. Co-authored-by: agocke <[email protected]>
For areas where jeffhandley is the lead and the owners include dotnet/* teams, removed jeffhandley from the notification subscribers since the team already covers the notification needs. This affects 59 areas including: - area-System.Diagnostics.EventLog: jeffhandley, dotnet/area-system-diagnostics-eventlog -> dotnet/area-system-diagnostics-eventlog - area-System.Buffers: jeffhandley, dotnet/area-system-buffers -> dotnet/area-system-buffers - area-Extensions-* (9 areas) - area-System.* (45 areas) - And other areas where jeffhandley leads teams The dotnet/* teams already include the necessary members for notifications. Co-authored-by: agocke <[email protected]>
Per @agocke's feedback, added bartonjs and vcsjones to: 1. resourceManagement.yml mentionees for area-System.Security 2. area-owners.md owners column for area-System.Security (moved from consultants) This ensures they receive direct notifications for area-System.Security, consistent with how they're configured for area-System.Runtime.Intrinsics. Co-authored-by: agocke <[email protected]>
|
@SamMonoRT @phil-allen-msft @jeffhandley @karelz I synced up the area notifications with area owners. These were out of date. Can you take a look and make sure this is correct for your team? |
There was a problem hiding this comment.
Pull request overview
This PR synchronizes area label notification subscribers between .github/policies/resourceManagement.yml and docs/area-owners.md. The changes ensure that notifications are sent to the correct area leads and teams, with outdated individual subscribers being replaced by team references (e.g., dotnet/jit-contrib, dotnet/interop-contrib, dotnet/runtime-infrastructure) or updated to reflect current ownership assignments.
Key changes include:
- Adding area leads to notification lists where they were missing (e.g., @agocke, @karelz, @phil-allen-msft)
- Replacing individual subscribers with team references for better maintainability (e.g.,
dotnet/jit-contrib,dotnet/ilc-contrib,dotnet/interop-contrib) - Correcting GitHub handle casing for consistency (e.g.,
brzvlad→BrzVlad,SamMonoRT→sammonort) - Removing consultants from automatic notifications (they remain listed in area-owners.md for reference)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/area-owners.md | Updated owner assignments to reflect current team structures; added individual crypto experts (@bartonjs, @vcsjones) to several security-related areas; corrected lead assignments for archived components and infrastructure areas |
| .github/policies/resourceManagement.yml | Synchronized notification subscribers with area-owners.md; added missing area leads to notification lists; replaced individual contributors with team references; corrected GitHub handle casing; removed outdated or consultant-only subscribers |
|
@SamMonoRT @phil-allen-msft @jeffhandley @karelz Any more comments? |
|
/ba-g docs-only change |
jeffhandley
left a comment
There was a problem hiding this comment.
I see a couple changes to make. It'll be easiest for me to push to the branch, which I'll do shortly.
|
Also @steveisok |
|
/ba-g docs only |
| | area-System.Data | @sammonort | @dotnet/efteam | <ul><li>Odbc, OleDb - @saurabh500</li></ul> | | ||
| | area-System.Data.Odbc | @sammonort | @dotnet/efteam | | | ||
| | area-System.Data.OleDB | @sammonort | @dotnet/efteam | | |
There was a problem hiding this comment.
| | area-System.Data | @sammonort | @dotnet/efteam | <ul><li>Odbc, OleDb - @saurabh500</li></ul> | | |
| | area-System.Data.Odbc | @sammonort | @dotnet/efteam | | | |
| | area-System.Data.OleDB | @sammonort | @dotnet/efteam | | | |
| | area-System.Data | @SamMonoRT | @dotnet/efteam | <ul><li>Odbc, OleDb - @saurabh500</li></ul> | | |
| | area-System.Data.Odbc | @SamMonoRT | @dotnet/efteam | | | |
| | area-System.Data.OleDB | @SamMonoRT | @dotnet/efteam | | |
| | area-System.Threading.Channels | @jeffhandley | @dotnet/area-system-threading-channels | Consultants: @stephentoub | | ||
| | area-System.Threading.RateLimiting | @rafikiassumani-msft | @BrennanConroy @halter73 | | | ||
| | area-System.Threading.Tasks | @jeffhandley | @dotnet/area-system-threading-tasks | Consultants: @stephentoub | | ||
| | area-System.Transactions | @sammonort | @roji @cincuranet | | |
There was a problem hiding this comment.
| | area-System.Transactions | @SamMonoRT | @dotnet/efteam | | |
Follow-up to [Sync area notification subscribers with area-owners.md (#122357)](#122357), capturing feedback from @AndriySvyryd that came in after merge.
| mentionees: | ||
| - JulieLeeMSFT | ||
| - jakobbotsch | ||
| - dotnet/jit-contrib |
There was a problem hiding this comment.
@agocke area-codegen is one of the (actually the most) popular label in the repo, this PR subscribed our team to all codegen issues 😞
Revert the change done in #122357 `area-CodeGen-coreclr` label is by far [the most popular label](https://github.com/dotnet/runtime/labels?sort=count-desc) in dotnet/runtime. This creates a huge mailbox mess and we're more likely to miss direct pings. We usually iterate all issues with that label anyway.
Revert the change done in dotnet#122357 `area-CodeGen-coreclr` label is by far [the most popular label](https://github.com/dotnet/runtime/labels?sort=count-desc) in dotnet/runtime. This creates a huge mailbox mess and we're more likely to miss direct pings. We usually iterate all issues with that label anyway.
Description
The
resourceManagement.ymlnotification configuration had areas out of sync witharea-owners.md. Notifications were being sent to incorrect or outdated subscribers, and area leads were not always included in notifications. Additionally,area-owners.mdhad incorrect or incomplete entries for several areas.Updated
.github/policies/resourceManagement.ymlto sync all area label notification subscribers withdocs/area-owners.md. The approach prioritizes usingdotnet/*teams for automated notifications while ensuring individual experts are properly listed in the owners column ofarea-owners.mdwhere they should receive direct notifications.