Collection expressions: add spreads section#7664
Open
cston wants to merge 2 commits intodotnet:mainfrom
Open
Conversation
|
|
||
| The `GetEnumerator` method identified in the compile-time processing may be an extension method. | ||
|
|
||
| The `Current` property identified in the compile-time processing may be *ref returning*. |
Contributor
There was a problem hiding this comment.
do we need language talking about when teh expression that is being spread is evaluated, versus when teh values are enumerated, and what guarantees there are (or are not) around that? (or does that already exist?
Contributor
Author
There was a problem hiding this comment.
The order of evaluation should be covered in the Construction section that follows this one.
CyrusNajmabadi
approved these changes
Nov 8, 2023
jnm2
approved these changes
Nov 8, 2023
|
|
||
| * `Ei` is an *expression element* and there is an implicit conversion from `Ei` to `T`. | ||
| * `Ei` is a *spread element* `Si` and there is an implicit conversion from the *iteration type* of `Si` to `T`. | ||
| * `Ei` is a *spread element* and there is an implicit conversion from the *iteration type* of the spread element *collection* to `T`. |
Contributor
There was a problem hiding this comment.
The term 'collection' surprises me a bit since any enumerable can be spread, and not all enumerables are collections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.