LDEV-6083 lazy BufferedImage decode, remove Commons Imaging from metadata path#34
Open
zspitzer wants to merge 5 commits into
Open
LDEV-6083 lazy BufferedImage decode, remove Commons Imaging from metadata path#34zspitzer wants to merge 5 commits into
zspitzer wants to merge 5 commits into
Conversation
zspitzer
force-pushed
the
LDEV-6083-metadata
branch
from
c88ec3d to
dd6bff1
Compare
zspitzer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Metadata ops (
imageInfo,imageGetEXIFMetadata,imageGetIPTCMetadata,imageGetWidth/Height) no longer force a fullBufferedImagedecode. Commons Imaging is also removed from the metadata path entirely — orientation now comes from Drew.Why
Metadata ops on a 3MB JPEG were decoding ~40MB of pixels just to read
Make/Model. Drew reads only the header bytes.Numbers (9950X3D, mixed 333-file corpus)
imageInfowarmimageGetEXIFMetadataJFR: the Commons Imaging GIF LZW hotspot is eliminated entirely (was 96 samples, now 0).
Tests
LDEV0006(pre-existing 185-vs-137 EXIF field count, unrelated)tests/LDEV6083lazy.cfc— 7 assertions failing on master (red phase), passing here (green). PublicImage.isDecoded()added as the test hook.Not in this PR
ApacheImagingCoderandJPEGDecoderstill use Commons Imaging for pixel decode (PCX/PNM/WBMP, custom JPEG CMYK). Separate decision, not a metadata concern.https://luceeserver.atlassian.net/browse/LDEV-6083