Skip to content

fix: Update dovecot-fts-xapian to 1.7.13#4095

Merged
polarathene merged 4 commits intomasterfrom
fix/update-xapian-to-1.7.13
Jul 3, 2024
Merged

fix: Update dovecot-fts-xapian to 1.7.13#4095
polarathene merged 4 commits intomasterfrom
fix/update-xapian-to-1.7.13

Conversation

@polarathene
Copy link
Copy Markdown
Member

@polarathene polarathene commented Jul 3, 2024

Description

Reported with cause identified as a regression upstream.

Upstream doesn't seem to maintain a changelog and the release just states "bug fixes", 1.7.13 was released in May 2024.

Updating to this release contains a fix to a regression that introduced a bug with indexing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

Contains a fix to a regression introduced that broke indexing
@polarathene polarathene added this to the v14.1.0 milestone Jul 3, 2024
casperklein
casperklein previously approved these changes Jul 3, 2024
georglauterbach
georglauterbach previously approved these changes Jul 3, 2024
@casperklein casperklein dismissed stale reviews from georglauterbach and themself via 8ef503e July 3, 2024 10:08
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Jul 3, 2024

Build seems to be failing; can you investigate @polarathene?

EDIT: @casperklein already did :D

@casperklein
Copy link
Copy Markdown
Member

Build seems to be failing; can you investigate @polarathene?

Should be fixed, see my last commit.

@polarathene
Copy link
Copy Markdown
Member Author

Yeah I just noticed the failure myself and was going to comment on why we have this handled in the Dockerfile instead of a related script method?

COPY --from=stage-compile dovecot-fts-xapian-1.7.12_1.7.12_*.deb /
RUN dpkg -i /dovecot-fts-xapian-1.7.12_1.7.12_*.deb && rm /dovecot-fts-xapian-1.7.12_1.7.12_*.deb

@casperklein
Copy link
Copy Markdown
Member

why we have this handled in the Dockerfile instead of a related script method?

COPY --from=stage-compile dovecot-fts-xapian-1.7.12_1.7.12_*.deb /
RUN dpkg -i /dovecot-fts-xapian-1.7.12_1.7.12_*.deb && rm /dovecot-fts-xapian-1.7.12_1.7.12_*.deb

I guess it was done, to not have the build deps in the final image.

@polarathene
Copy link
Copy Markdown
Member Author

I guess it was done, to not have the build deps in the final image.

I meant keep the version specific parts in a helper function instead of via RUN. But I guess since we already have run build.sh before compile.sh neither is really suitable for it?

Could perhaps avoid having the version in the .deb filename, but I'm not 100% sure how that affects the layer caching, it should be invalidated with the COPY directive right?

@polarathene polarathene merged commit 9175424 into master Jul 3, 2024
@polarathene polarathene deleted the fix/update-xapian-to-1.7.13 branch July 3, 2024 10:16
@casperklein
Copy link
Copy Markdown
Member

I meant keep the version specific parts in a helper function instead of via RUN

That is "fixed" now.

it should be invalidated with the COPY directive right?

Idk 🤷

@georglauterbach georglauterbach modified the milestones: v14.1.0, v15.0.0 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants