Skip to content

feat: Configurable number of rotated log files#3907

Merged
georglauterbach merged 2 commits intodocker-mailserver:masterfrom
doominator42:master
Feb 28, 2024
Merged

feat: Configurable number of rotated log files#3907
georglauterbach merged 2 commits intodocker-mailserver:masterfrom
doominator42:master

Conversation

@doominator42
Copy link
Copy Markdown
Contributor

@doominator42 doominator42 commented Feb 24, 2024 •
edited
Loading

Description

Since there is the variable LOGROTATE_INTERVAL, it would be useful to be able to adjust the number of files kept by logrotate, so I added LOGROTATE_COUNT.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@doominator42
Copy link
Copy Markdown
Contributor Author

doominator42 commented Feb 24, 2024

I was not sure about the format of the CHANGELOG, should I add a section Added with my change or add it under Updates?

@casperklein
Copy link
Copy Markdown
Member

casperklein commented Feb 24, 2024

Added is good for new features 👍

@doominator42
feat: Configurable number of rotated log files
4a42c92 
Added the environment variable LOGROTATE_COUNT (defaults to 4)
@doominator42
Copy link
Copy Markdown
Contributor Author

doominator42 commented Feb 25, 2024

I added my change to the CHANGELOG, this PR is now ready for review.

@casperklein casperklein added this to the v14.0.0 milestone Feb 25, 2024
@casperklein casperklein added the kind/new feature A new feature is requested in this issue or implemeted with this PR label Feb 25, 2024
georglauterbach
georglauterbach approved these changes Feb 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 28, 2024

Documentation preview for this PR is ready! 🎉

Built with commit: aabea61

@georglauterbach georglauterbach merged commit 512f39c into docker-mailserver:master Feb 28, 2024
This was referenced Feb 29, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

No one assigned

Labels

kind/new feature A new feature is requested in this issue or implemeted with this PR

Projects

None yet

Milestone

v14.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@doominator42 @casperklein @georglauterbach