Skip to content

hotfix: solve #3665#3669

Merged
georglauterbach merged 4 commits intomasterfrom
rspamd/hotfix
Nov 28, 2023
Merged

hotfix: solve #3665#3669
georglauterbach merged 4 commits intomasterfrom
rspamd/hotfix

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Nov 27, 2023 •
edited
Loading

Description

This patch release fixes two bugs that Rspamd users encounter on v13.0.0:

  1. The check for correct permission on the private key when signing e-mails with DKIM was flawed. The result was that a false warning was emitted.
  2. When RSPAMD_CHECK_AUTHENTICATED=0, DKIM signing for outbound e-mail was disabled, which is undesirable.

Fixes #3665

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@georglauterbach georglauterbach added this to the v13.0.1 milestone Nov 27, 2023
@georglauterbach georglauterbach self-assigned this Nov 27, 2023
@georglauterbach georglauterbach mentioned this pull request Nov 27, 2023
Closed
1 task
polarathene
polarathene requested changes Nov 27, 2023
View reviewed changes
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 27, 2023

Documentation preview for this PR is ready! 🎉

Built with commit: bc59f51

@polarathene polarathene mentioned this pull request Nov 27, 2023
Open
polarathene
polarathene approved these changes Nov 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Improved test coverage is deferred, an existing DKIM refactor issue will track that.

@georglauterbach georglauterbach merged commit a11951e into master Nov 28, 2023
@georglauterbach georglauterbach deleted the rspamd/hotfix branch November 28, 2023 09:33
@jessec jessec mentioned this pull request Nov 28, 2023
Closed
@apratasenia
Copy link
Copy Markdown

apratasenia commented Jun 7, 2024

I got the same issue after upgrading from 13.3.1 to 14.0.0. UID and GID are both seem to be correct (_rspamd:_rspamd) on /tmp/docker-mailserver/rspamd/dkim folder and all the files inside.

@apratasenia apratasenia mentioned this pull request Jun 7, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

Assignees

@georglauterbach georglauterbach

Labels

area/scripts kind/bug/fix A fix (PR) for a confirmed bug priority/high service/security/dkim-dmarc-spf service/security/rspamd

Projects

Rspamd Integration
Archived in project

Milestone

v13.0.1

Development

Successfully merging this pull request may close these issues.

bug report: Test on rspamd private key files not working as expected

3 participants

@georglauterbach @apratasenia @polarathene