ci: Add run-local-instance target to Makefile#3663
Merged
georglauterbach merged 3 commits intomasterfrom Dec 3, 2023
Merged
Conversation
georglauterbach
added
area/ci
kind/new feature
georglauterbach
force-pushed
the
add-test-command
branch
from
890b536 to
d88e0c4
Compare
georglauterbach
force-pushed
the
add-test-command
branch
from
d88e0c4 to
f1ac16d
Compare
georglauterbach
changed the title
run-example target to Makefilerun-local-instance target to Makefile
polarathene
previously approved these changes
Nov 26, 2023
Member
polarathene
left a comment
polarathene
left a comment
There was a problem hiding this comment.
LGTM 👍
If you would like to take the compose.yaml approach, I can put together a PR for that. The more full-fledged offline setup would have to wait, but adjusting your current approach to compose.yaml is simple enough as a few files in an example/ or similar folder.
run-local-instance might then be better as run-example. My future plans would be for having several common examples, which should be helpful to the community and reproductions for issues, and Docker Compose features really help simplify that 😎
casperklein
previously approved these changes
Dec 1, 2023
georglauterbach
dismissed stale reviews from casperklein and polarathene
via
fe06309
Contributor
|
Documentation preview for this PR is ready! 🎉 Built with commit: fe06309 |
Member
Author
|
FYI: Auto-merge is enabled |
polarathene
changed the title
run-local-instance target to Makefilerun-local-instance target to Makefile
polarathene
approved these changes
Dec 3, 2023
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a target to
Makefilewhich runs a simple version of DMS (anti-spam services disabled) to test local builds. I use this frequently.Fixes #
Type of change
Checklist:
docs/)CHANGELOG.md