Generate OSGi compliant manifest #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
=======================================
Coverage 71.64% 71.64%
=======================================
Files 306 306
Lines 6582 6582
Branches 483 483
=======================================
Hits 4716 4716
Misses 1580 1580
Partials 286 286
Continue to review full report at Codecov.
|
Member
|
@marcuslinke WDYT? |
added 2 commits
March 13, 2017 08:54
Manifest is generated by the Bundlor plugin according to the template defined in template.mf file. Import package versions are mainly derived from properties defined in pom.xml. Imports of Netty packages are marked as optional.
Contributor
|
As I've no experience with OSGI I can't say anything to this PR. But as no code was changed I think its OK to merge. |
Member
|
Let's try.. |
vuminhkh
added a commit
to alien4cloud/docker-java
that referenced
this pull request
Apr 30, 2017
* master-docker-java: (25 commits) Add some coding styles. Allow an explicit Dockerfile location string to be specified to the build command (docker-java#825) Proposed fix for docker-java#830 (docker-java#832) [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release 3.0.9 Fix test. Update CHANGELOG.md Responce may contains token. adding support for unless-stopped restart policy Generate OSGi compliant manifest (docker-java#797) exclude commons-logging since docker-java uses slf4j/logback Unable to deserialize status response from amazon ECR login Ensure FakeDockerServer is started on a random free port Fixes docker-java#807. NettyDockerCmdExecFactory ignores API version configuration [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release 3.0.8 Update CHANGELOG.md Added healthcheck support in container inspect JSON result Use TLSv2 by default rerun failing tests count to 3 ... # Conflicts: # pom.xml
panuse
pushed a commit
to TuKangTech/docker-java
that referenced
this pull request
Aug 20, 2017
* Generate OSGi compliant manifest Manifest is generated by the Bundlor plugin according to the template defined in template.mf file. Import package versions are mainly derived from properties defined in pom.xml. Imports of Netty packages are marked as optional. * Export com.github.dockerjava.core package and subpackages
Member
|
When i run test from idea it fails Open idea, click run on some test. |
Member
|
Removed IDEA OSGI facet, now fine. |
Member
|
@orzeh now build fails eclipse repo returning weird errors |
Contributor
Author
|
@KostyaSha maybe we should switch to BND I'll take a look on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manifest is generated by the Bundlor plugin according to the template defined in
template.mffile.Import package versions are mainly derived from properties defined in
pom.xml.Imports of Netty packages are marked as optional.
Bundle version is generated by the Build Helper plugin to be OSGi compliant when developing
SNAPSHOTs.This will fix #789
This change is