Skip to content

Fix it2 #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KostyaSha merged 2 commits into from
Jul 4, 2016
Merged

Fix it2 #621

KostyaSha merged 2 commits into from
Jul 4, 2016

Conversation

@KostyaSha
Copy link
Member

@KostyaSha KostyaSha commented Jul 4, 2016 •
edited
Loading

piece of #620

This change is Reviewable

@KostyaSha
Copy link
Member Author

KostyaSha commented Jul 4, 2016

@marcuslinke please review

KostyaSha
KostyaSha reviewed Jul 4, 2016
View reviewed changes
src/test/java/com/github/dockerjava/core/command/CreateContainerCmdImplTest.java
InspectContainerResponse inspectContainerResponse = dockerClient.inspectContainerCmd(container.getId()).exec();

assertThat(Arrays.asList(inspectContainerResponse.getConfig().getEnv()), containsInAnyOrder("VARIABLE=success"));
assertThat(Arrays.asList(inspectContainerResponse.getConfig().getEnv()), hasItem(testVariable));
Copy link
Member Author

@KostyaSha KostyaSha Jul 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arrays has two variables, so it should be hasItem

@KostyaSha
Copy link
Member Author

KostyaSha commented Jul 4, 2016

$ export DOCKER_HOST="unix:///var/run/docker.sock"
$ export DOCKER_VERSION="1.11.2-0~trusty"

Tests run: 301, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 511.534 sec <<< FAILURE! - in TestSuite
copyFileToContainer(com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest)  Time elapsed: 0.497 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyFileToContainer(CopyArchiveToContainerCmdImplTest.java:57)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@283818af; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyFileToContainer(CopyArchiveToContainerCmdImplTest.java:57)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyFileToContainer(CopyArchiveToContainerCmdImplTest.java:57)
copyStreamToContainer(com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest)  Time elapsed: 0.625 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyStreamToContainer(CopyArchiveToContainerCmdImplTest.java:66)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@611f5521; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyStreamToContainer(CopyArchiveToContainerCmdImplTest.java:66)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyStreamToContainer(CopyArchiveToContainerCmdImplTest.java:66)
testEventStreamTimeBound(com.github.dockerjava.core.command.EventsCmdImplTest)  Time elapsed: 31.438 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreamTimeBound(EventsCmdImplTest.java:68)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@61869e64; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreamTimeBound(EventsCmdImplTest.java:68)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreamTimeBound(EventsCmdImplTest.java:68)
testEventStreaming1(com.github.dockerjava.core.command.EventsCmdImplTest)  Time elapsed: 20.201 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming1(EventsCmdImplTest.java:87)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@5331429e; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming1(EventsCmdImplTest.java:87)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming1(EventsCmdImplTest.java:87)
Results :
Failed tests: 
  CopyArchiveToContainerCmdImplTest.copyFileToContainer:57->assertFileCopied:83 » Processing
  CopyArchiveToContainerCmdImplTest.copyStreamToContainer:66->assertFileCopied:83 » Processing
  EventsCmdImplTest.testEventStreamTimeBound:68 » Processing Error closing messa...
  EventsCmdImplTest.testEventStreaming1:87 » Processing Error closing message co...
Tests run: 301, Failures: 4, Errors: 0, Skipped: 0

@KostyaSha
Copy link
Member Author

KostyaSha commented Jul 4, 2016

$ export DOCKER_HOST="tcp://127.0.0.1:2375"
$ export DOCKER_VERSION="1.11.2-0~trusty"

Tests run: 301, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 503.064 sec <<< FAILURE! - in TestSuite
attachContainerWithTTY(com.github.dockerjava.core.command.AttachContainerCmdImplTest)  Time elapsed: 9.283 sec  <<< FAILURE!
java.lang.AssertionError: 
Expected: a string containing "stdout\r\nstderr"
     but: was ""
    at com.github.dockerjava.core.command.AttachContainerCmdImplTest.attachContainerWithTTY(AttachContainerCmdImplTest.java:108)
Results :
Failed tests: 
  AttachContainerCmdImplTest.attachContainerWithTTY:108 
Expected: a string containing "stdout\r\nstderr"
     but: was ""
Tests run: 301, Failures: 1, Errors: 0, Skipped: 0

@KostyaSha
Copy link
Member Author

KostyaSha commented Jul 4, 2016

Changes looks right, merging.

@KostyaSha KostyaSha merged commit 04fa7e8 into master Jul 4, 2016
@KostyaSha KostyaSha deleted the fixIT2 branch July 4, 2016 19:04
panuse pushed a commit to TuKangTech/docker-java that referenced this pull request Aug 20, 2017
@KostyaSha
Fix it2 (docker-java#621)
3d6c42e 
* Fix hasItem in test

* Disable toolbox only tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KostyaSha