Skip to content

Conversation

@KostyaSha
Copy link
Member

@KostyaSha KostyaSha commented Jun 16, 2016

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Jun 16, 2016

Current coverage is 23.44%

Merging #606 into master will decrease coverage by <.01%

@@             master       #606   diff @@
==========================================
  Files           296        296          
  Lines          6255       6257     +2   
  Methods           0          0          
  Messages          0          0          
  Branches        558        559     +1   
==========================================
  Hits           1467       1467          
- Misses         4691       4693     +2   
  Partials         97         97          

Powered by Codecov. Last updated by 2f8d317...6e3eaec

@KostyaSha
Copy link
Member Author

@marcuslinke almost done :D

@KostyaSha
Copy link
Member Author

@marcuslinke IT bit sucks. Test connection builder shouldn't rely on system vars, or should respect them. No idea how it was designed. I think i made working integration tests.
Still wish to have junit!

@KostyaSha
Copy link
Member Author

fast build should be the same as it was before. Other - ITs.

@KostyaSha
Copy link
Member Author

@marcuslinke done, i would have no time now to fix test errors. Also see that 1.12 will break HostConfig a lot :)

@KostyaSha
Copy link
Member Author

KostyaSha commented Jun 17, 2016

Main build is still here -> let's squash merge.
Also I added special user for dockerhub in travis settings, feel free to try fix this IT errors.

@KostyaSha KostyaSha closed this Jun 17, 2016
@KostyaSha KostyaSha reopened this Jun 17, 2016
@KostyaSha KostyaSha merged commit 2116ae0 into docker-java:master Jun 17, 2016
@KostyaSha KostyaSha added this to the 3.0.1 milestone Jun 17, 2016
panuse pushed a commit to TuKangTech/docker-java that referenced this pull request Aug 20, 2017
Fast build - without integration tests.
ITs - against different docker versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants