Allow null value. boolean <-> Boolean error #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dockerCertPath; | ||
|
|
||
| private boolean dockerTlsVerify; | ||
| private Boolean dockerTlsVerify; |
Member
Author
There was a problem hiding this comment.
either setter should use boolean. If null - then docker-java default.
Member
Author
|
@marcuslinke please review |
Contributor
|
@KostyaSha LGTM! |
Contributor
|
@KostyaSha Oh, a test is failing! Haven' seen this before. So it doesn't LGTM ;) |
Current coverage is 23.45%@@ master #605 diff @@
==========================================
Files 296 296
Lines 6255 6255
Methods 0 0
Messages 0 0
Branches 558 558
==========================================
Hits 1467 1467
Misses 4691 4691
Partials 97 97
|
Member
Author
|
@marcuslinke sorry, fixed |
|
|
||
| builder.withDockerTlsVerify("FALSE"); | ||
| assertThat(field.getBoolean(builder), is(false)); | ||
| assertThat((Boolean) field.get(builder), is(false)); |
Member
Author
There was a problem hiding this comment.
btw, why not move setters directly into class, then getters would work?
Contributor
There was a problem hiding this comment.
Sorry, don't get it...
Member
Author
There was a problem hiding this comment.
field is object, getBoolean() works only with primitive
panuse
pushed a commit
to TuKangTech/docker-java
that referenced
this pull request
Aug 20, 2017
Allow null value. boolean <-> Boolean error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is