Skip to content

Conversation

@bonigarcia
Copy link
Contributor

There is a bug in the mapping of the network statistics. Currently, calling to com.github.dockerjava.api.model.Statistics.getNetworkStats() returns null.

@KostyaSha
Copy link
Member

Could you provide info on what docker version have you checked, could you try to create a test case? Could you check that it wasn't changed between different docker API versions?

@bonigarcia
Copy link
Contributor Author

I am using Docker version 1.9.0, build 76d6bc9.

@bonigarcia
Copy link
Contributor Author

I tested with docker-java 2.1.1, 2.1.2 and 3.0.0-SNAPSHOT. Both of three have the same bug.

@KostyaSha
Copy link
Member

Sorry, i mean docker host API

@bonigarcia
Copy link
Contributor Author

I am using Docker 1.9.0, and according to Docker documentation, API version should be 1.21.

@marcuslinke
Copy link
Contributor

@KostyaSha
Copy link
Member

@marcuslinke seems it because it now support multiple interfaces. The right way to fix will be add new field, mark as @Deprecated with specifying docker API versions.

@KostyaSha
Copy link
Member

moby/moby#16564

@marcuslinke
Copy link
Contributor

@KostyaSha Right. I agree.

@bonigarcia Could you do so?

@KostyaSha
Copy link
Member

@bonigarcia next time please better force push to this PR and change title according. Will allow easier find discussion for changes.
PS crosslinked PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants