Skip to content

Align Jackson dependencies using the Jackson BOM #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yeikel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Align Jackson dependencies using the Jackson BOM #2446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docker-java-transport-jersey/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
<dependency>
<groupId>com.fasterxml.jackson.jaxrs</groupId>
<artifactId>jackson-jaxrs-json-provider</artifactId>
<version>${jackson-jaxrs.version}</version>
</dependency>
<dependency>
<groupId>org.glassfish.jersey.connectors</groupId>
Expand Down
4 changes: 0 additions & 4 deletions docker-java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,16 +125,12 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<!-- Force the version to 2.18.3 to ensure the compatibility with old projects -->
<version>2.18.3</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<!-- Force the version to 2.18.3 to ensure the compatibility with old projects -->
<version>2.18.3</version>
<scope>test</scope>
</dependency>

Expand Down
15 changes: 13 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@
<jdk.target>1.8</jdk.target>

<jersey.version>2.30.1</jersey.version>
<jackson.version>2.18.3</jackson.version>
Copy link
Author

@yeikel yeikel May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is a bit vague. I am not sure what "old projects" refers to here because there are no recent breaking changes in jackson.

Is this an outdated comment?

Copy link
Author

@yeikel yeikel May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddumelendez I'd appreciate your input here

<jackson-jaxrs.version>2.18.3</jackson-jaxrs.version>
<jackson.version>2.18.3</jackson.version> <!-- Force the version to 2.18.3 to ensure the compatibility with old projects -->
<httpclient.version>4.5.12</httpclient.version><!-- 4.5.1-4.5.2 broken -->
<commons-compress.version>1.27.1</commons-compress.version>
<commons-io.version>2.18.0</commons-io.version>
Expand Down Expand Up @@ -104,6 +103,18 @@
<module>docker-java</module>
</modules>

<dependencyManagement>
<dependencies>
<dependency>
<groupId>com.fasterxml.jackson</groupId>
<artifactId>jackson-bom</artifactId>
<version>${jackson.version}</version>
<scope>import</scope>
<type>pom</type>
</dependency>
</dependencies>
</dependencyManagement>

<build>
<pluginManagement>
<plugins>
Expand Down