Fix #1726 by disabling stale connection checking in AHC5 #1727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alls Avoiding checking for stale resolve the issue for me
Member
|
@tyge68 wow, great finding! Thanks. Triggered the CI run, will merge once green 👍 |
Contributor
Author
|
@bsideup do you have some info about when it will be merged ? and around when there will be a new release for it ? |
bsideup
approved these changes
Nov 2, 2021
bsideup
changed the title
Member
|
Hi @tyge68, I just merged the PR, thanks! I will try to merge a couple of other things and do a release relatively soon 👍 |
|
@bsideup any updates on when a release would be available? I believe my team has encountered this same issue a couple times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1726 in order to make sure it doesn't fail on stale connection checking, it need to be disabled via the "setValidateAfterInactivity" setup (default is set to 2 seconds in the PoolingHttpClientConnectionManager.
Avoiding checking for stale resolve the issue for me